search

knative / build-templates

A library of build templates.
Apache License 2.0
184 stars 68 forks source link

vendor in docker-credential-gcr #100

Open jamesward opened 5 years ago

jamesward commented 5 years ago

This vendors in docker-credential-gcr so that no special service accounts are needed to publish to GCR. This is similar to how the CNCF Buildpacks vendor in the creds helpers: https://github.com/buildpack/lifecycle/blob/master/images/build/Dockerfile#L6-L8

knative-prow-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jamesward To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: mattmoor

If they are not already assigned, you can assign the PR to them by writing /assign @mattmoor in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/build-templates/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
imjasonh commented 5 years ago

/ok-to-test

imjasonh commented 5 years ago

Should we also do this for the jib-gradle template?

cc @loosebazooka