Closed Vantage-Collabo closed 5 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
ℹ️ Googlers: Go here for more info.
Hi @Vantage-Collabo. Thanks for your PR.
I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.
This PR doesn't contain any meaningful changes, and it's hard to tell from the description what the intention of it was. If you'd like some help contributing a build template to this repo, let me know and I'd be happy to help however I can.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Vantage-Collabo To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: mattmoor
If they are not already assigned, you can assign the PR to them by writing
/assign @mattmoor
in a comment when ready.The full list of commands accepted by this bot can be found here.
The pull request process is described here