search

knative / build-templates

A library of build templates.
Apache License 2.0
184 stars 68 forks source link

Update test-infra dependency #105

Closed nbarthwal closed 5 years ago

nbarthwal commented 5 years ago

Update the test-infra dependency in vendor using dep update

nbarthwal commented 5 years ago

/cc adrcunha

nbarthwal commented 5 years ago

/uncc mattmoor

imjasonh commented 5 years ago

/lgtm /approve

knative-prow-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH, nbarthwal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/build-templates/blob/master/OWNERS)~~ [ImJasonH] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nbarthwal commented 5 years ago

/retest

adrcunha commented 5 years ago

/retest won't work. If you check the logs, you'll see that a function is missing.

https://github.com/knative/build-templates/pull/102 must be approved/merged first, or this PR won't pass the presubmit tests.

nbarthwal commented 5 years ago

Let me ping Jason for 102 and then redo it.

On Apr 5, 2019, at 11:29 AM, Adriano Cunha notifications@github.com wrote:

/retest won't work. If you check the logs, you'll see that a function is missing.

102 https://github.com/knative/build-templates/pull/102 must be approved/merged first, or this PR won't pass the presubmit tests.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/knative/build-templates/pull/105#issuecomment-480377990, or mute the thread https://github.com/notifications/unsubscribe-auth/AsL15oBznMjXM4eLNXyFbAvYid47cfzHks5vd5YVgaJpZM4cfdLl.

adrcunha commented 5 years ago

You don't have to redo this PR.

nbarthwal commented 5 years ago

/retest

knative-prow-robot commented 5 years ago

@nbarthwal: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-build-templates-integration-tests 7d147f7c2422fe861d90bed985ac564e37cdf8de link /test pull-knative-build-templates-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
adrcunha commented 5 years ago

@nbarthwal please solve the conflicts

nbarthwal commented 5 years ago

/hold

nbarthwal commented 5 years ago

Closed as a new one is sent!