search

knative / build-templates

A library of build templates.
Apache License 2.0
184 stars 68 forks source link

Add context for kaniko #107

Closed salrashid123 closed 5 years ago

salrashid123 commented 5 years ago

Adding context argument for kaniko

I can add in the the other arguments as part of this PR if needed. Unsure how to accomodate repeated values of --build-arg though

knative-prow-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: salrashid123 To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: mattmoor

If they are not already assigned, you can assign the PR to them by writing /assign @mattmoor in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/build-templates/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vdemeester commented 5 years ago

/ok-to-test

houshengbo commented 5 years ago

@salrashid123 I left some more comments hoping they are useful.

salrashid123 commented 5 years ago

@ImJasonH Could we startoff the review on this (its a change that'd allow flexiblity in builds (e,g i needed this change since my dockerfile was in a subfolder from a git root).