search

knative / build-templates

A library of build templates.
Apache License 2.0
184 stars 68 forks source link

Fix typo in readme #114

Closed huoqifeng closed 5 years ago

huoqifeng commented 5 years ago

Signed-off-by: huoqifeng huoqif@cn.ibm.com

googlebot commented 5 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

knative-prow-robot commented 5 years ago

Hi @huoqifeng. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
huoqifeng commented 5 years ago

/retest

imjasonh commented 5 years ago

The failures are related to markdown lint errors which haven't always been enforced. If you want to fix them that's fine, otherwise I'll make the changes on your branch.

huoqifeng commented 5 years ago

@ImJasonH let me fix it. I'd like to use this PR to start my journey in knative, thanks for the review!

huoqifeng commented 5 years ago

@ImJasonH the lint err is fixed, may you help review again and merge it? ~I noticed there is a CLA warning but it's actually signed and can been found here: https://cla.developers.google.com/clas after login by any of my email registered in my account. still not figured out why..But I think which won't block your merging... thanks!~ fixed the cla.

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

huoqifeng commented 5 years ago

@ImJasonH @mattmoor would you mind have a look at the PR? this is my first contribution to the project, I'm happy to continue my efforts once it's get merged.

knative-prow-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huoqifeng, ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/build-templates/blob/master/OWNERS)~~ [ImJasonH] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment