Open zhangtbj opened 5 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: zhangtbj To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: mattmoor
If they are not already assigned, you can assign the PR to them by writing /assign @mattmoor
in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Hi @zhangtbj. Thanks for your PR.
I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test /lgtm
The original link doesn't exist and report 404 page not found. I corrected the page link to the right url.
Signed-off-by: zhangtbj zhangtbj@cn.ibm.com