knative / build-templates

A library of build templates.
Apache License 2.0
184 stars 68 forks source link

Update CNB template for latest lifecycle #119

Closed ameyer-pivotal closed 5 years ago

ameyer-pivotal commented 5 years ago

Signed-off-by: Andrew Meyer ameyer@pivotal.io

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

knative-prow-robot commented 5 years ago

Hi @ameyer-pivotal. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ameyer-pivotal commented 5 years ago

CLA issue should be fixed

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

ameyer-pivotal commented 5 years ago

/assign @imjasonh

mattmoor commented 5 years ago

/ok-to-test

ameyer-pivotal commented 5 years ago

It looks like this removes RUN_IMAGE, is that no longer an option the user can set?

@ImJasonH That's correct. The run image is derived from the builder image now.

ameyer-pivotal commented 5 years ago

@ImJasonH Do you have any more questions I can answer for you, or is this ready to merge?

FYI: I'm also working on a similar PR at the moment for Tekton, as I know Knative Build is deprecated, but this could still be useful for folks.

knative-prow-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameyer-pivotal, ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/build-templates/blob/master/OWNERS)~~ [ImJasonH] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment