Closed ameyer-pivotal closed 5 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
ℹ️ Googlers: Go here for more info.
Hi @ameyer-pivotal. Thanks for your PR.
I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
CLA issue should be fixed
/assign @imjasonh
/ok-to-test
It looks like this removes
RUN_IMAGE
, is that no longer an option the user can set?
@ImJasonH That's correct. The run image is derived from the builder image now.
@ImJasonH Do you have any more questions I can answer for you, or is this ready to merge?
FYI: I'm also working on a similar PR at the moment for Tekton, as I know Knative Build is deprecated, but this could still be useful for folks.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ameyer-pivotal, ImJasonH
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Signed-off-by: Andrew Meyer ameyer@pivotal.io