search

knative / build-templates

A library of build templates.
Apache License 2.0
183 stars 67 forks source link

[WIP] Add Node FTL build template #15

Closed imjasonh closed 6 years ago

imjasonh commented 6 years ago

Open Questions:

1.) What builder image should be used?

Is there some more sane tag that can be used?

2.) What base image should be used by default?

Is there some more sane tag that can be used?

3.) Should entrypoint be a build template paramater?

4.) Are there any more options that are accepted by the FTL builder image?

5.) Can we take this opportunity to document FTL better? Otherwise, the FTL README.md is pretty scant. 🙁

Fixes #5

google-prow-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/elafros/build-templates/blob/master/OWNERS)~~ [ImJasonH] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
imjasonh commented 6 years ago

/cc @aaron-prindle

google-prow-robot commented 6 years ago

@ImJasonH: GitHub didn't allow me to request PR reviews from the following users: aaron-prindle.

Note that only elafros members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/elafros/build-templates/pull/15#issuecomment-392300118): >/cc @aaron-prindle Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.