Closed evankanderson closed 6 years ago
Could we have a way to specify which k8s namespace to put things in? I'd rather not have to change the default namespace for my kubectl context just for this step.
Why not putting this script in //hack, together with the other scripts?
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: evankanderson To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: imjasonh
Assign the PR to them by writing /assign @imjasonh
in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Re @enisoc -- added positional arguments for namespace ($1) and kubernetes SA ($2) Re @adrcunha -- this script is intended for use by operators and/or developers who are looking to use the builds, not for contributors, which is what I'd expect //hack to be for. Additionally, build-templates doesn't have a //hack directory at all.
Updated, PTAL.
Updated docs, do you want to take a look again, @ImJasonH
/lgtm /woof space
Fixes #21
This automates the creation of GCP credentials, permissions application on GCR buckets, and creation of kubernetes secrets in the current namespace using the
_json_key
style of secret.Sorry about the shell script -- it seemed like the most readable/useful option, though the
jq
usage is a bit tricky.