search

knative / build-templates

A library of build templates.
Apache License 2.0
183 stars 67 forks source link

Mac support for gcr_helper #40

Closed scothis closed 6 years ago

scothis commented 6 years ago

The base64 command is using the -w flag to disable wrapping. On the Mac the equivalent flag is -b. There is no common flag that will disable wrapping.

One option is to use openssl base64 -a -A. I'm not sure that's the right answer, but I'm opening a PR to start the discussion.

/assign @ImJasonH

google-prow-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH, scothis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/build-templates/blob/master/OWNERS)~~ [ImJasonH] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment