search

knative / build-templates

A library of build templates.
Apache License 2.0
184 stars 68 forks source link

buildah: better out-of-the-gate usage #54

Closed vbatts closed 6 years ago

vbatts commented 6 years ago

Some of the env variables are generic enough for now to be included in the builder_image itself. This will play in for making a non-Dockerfile build template as well.

As for the --tls-verify=false, I'm not pleased with that and will be working on better specific registry toggling in buildah (that is not twiddling a TOML file in /etc/containers/). Though there is also the issue of having a conditional provided by kubernetes or knative or from the end build job of which insecure-registry's are to be set. That is likely a plumbing discussion to be had

Signed-off-by: Vincent Batts vbatts@hashbangbash.com

vbatts commented 6 years ago

PTAL

imjasonh commented 6 years ago

/lgtm /approve

knative-prow-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH, vbatts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/build-templates/blob/master/OWNERS)~~ [ImJasonH] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vbatts commented 6 years ago

when y'all do squash merges, it changes the commit author and loses the gpg commit signature :-\

imjasonh commented 6 years ago

/test pull-knative-build-templates-integration-tests