Closed scothis closed 6 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: scothis To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: imjasonh
Assign the PR to them by writing /assign @imjasonh
in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/assign @imjasonh @sclevine
CLAs look good, thanks!
@ImJasonH addressed your feedback. Looks like there's no good link for multi-buildpack support from a perspective meaningful for elafros users, so I added a blurb inline. The best we came up with was https://docs.cloudfoundry.org/buildpacks/understand-buildpacks.html which is for buildpack authors.
@sclevine @ImJasonH This PR is ready for a fresh review. The implementation has shifted quite a bit since the original PR. Would you prefer to keep the history or squash the commits into something more meaningful?
The buildpack-skipdetect build template is a derivative of the buildpack build template that adds configuration support for:
In the long run, this build template and the buildpack build template should merge into a single configurable build template.