knative / build-templates

A library of build templates.
Apache License 2.0
183 stars 67 forks source link

Add buildpack-skipdetect build template #6

Closed scothis closed 6 years ago

scothis commented 6 years ago

The buildpack-skipdetect build template is a derivative of the buildpack build template that adds configuration support for:

In the long run, this build template and the buildpack build template should merge into a single configurable build template.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
google-prow-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: scothis To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: imjasonh

Assign the PR to them by writing /assign @imjasonh in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/elafros/build-templates/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
scothis commented 6 years ago

/assign @imjasonh @sclevine

googlebot commented 6 years ago

CLAs look good, thanks!

scothis commented 6 years ago

@ImJasonH addressed your feedback. Looks like there's no good link for multi-buildpack support from a perspective meaningful for elafros users, so I added a blurb inline. The best we came up with was https://docs.cloudfoundry.org/buildpacks/understand-buildpacks.html which is for buildpack authors.

scothis commented 6 years ago

@sclevine @ImJasonH This PR is ready for a fresh review. The implementation has shifted quite a bit since the original PR. Would you prefer to keep the history or squash the commits into something more meaningful?