Closed ekcasey closed 5 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
I was just added to the Pivotal group of authorized contributors so I am covered by the corporate CLA.
So there's good news and bad news.
:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.
:confused: The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.
Note to project maintainer: This is a terminal state, meaning the cla/google
commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla
label to yes
(if enabled on your project), and then merge this pull request when appropriate.
@ImJasonH Where are we on this PR? Are any of these concerns still outstanding?
/retest
Looking at the e2e test failure, it seems as though we broke it by renaming buildpack/buildpack.yaml
to buildpack/cf.yaml
.
@ekcasey I think we'll need to edit this PR to get it through the e2e spec.
@jchesterpivotal and I fixed the e2e tests and added a new one for the buildpacks-cnb
template.
@ImJasonH @jonjohnsonjr let us know if you have any comments :)
/check-cla
/assign @ImJasonH
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ekcasey, ImJasonH
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
So there's good news and bad news.
:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.
:confused: The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.
Note to project maintainer: This is a terminal state, meaning the cla/google
commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla
label to yes
(if enabled on your project), and then merge this pull request when appropriate.
We made some significant changes to this PR, so that the build template uses our the new v3alpha2
lifecycle. Now that the step image is configurable we also added some params to allow users to supply their own builder image.
We also fixed the template names in the buildpacks READMEs.
I was just added to the Pivotal group of authorized contributors so I should be covered by the corporate CLA. I am ok with my commits being contributed to this project
/check-cla
Should the exporter step mount the docker socket and use -daemon
?
The CNB exporter is much less efficient when exporting to a daemon instead of a registry. When exporting to a registry, the exporter can upload just the layers that have changed, regardless of their order within the image.
Additionally, the whole process currently works in unprivileged containers. Poking the daemon socket through would make it less suitable for building untrusted code. (That said, I'm not sure what privileges containers currently have in build CRD.)
/lgtm
Intended to replace https://github.com/knative/build-templates/pull/65
knative-helper