knative / build-templates

A library of build templates.
Apache License 2.0
183 stars 67 forks source link

Adds template for Cloud Native Buildpacks #67

Closed ekcasey closed 5 years ago

ekcasey commented 6 years ago

Intended to replace https://github.com/knative/build-templates/pull/65

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
ekcasey commented 6 years ago

I was just added to the Pivotal group of authorized contributors so I am covered by the corporate CLA.

googlebot commented 6 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ekcasey commented 6 years ago

@ImJasonH Where are we on this PR? Are any of these concerns still outstanding?

jchesterpivotal commented 6 years ago

/retest

jchesterpivotal commented 6 years ago

Looking at the e2e test failure, it seems as though we broke it by renaming buildpack/buildpack.yaml to buildpack/cf.yaml.

@ekcasey I think we'll need to edit this PR to get it through the e2e spec.

ekcasey commented 6 years ago

@jchesterpivotal and I fixed the e2e tests and added a new one for the buildpacks-cnb template.

@ImJasonH @jonjohnsonjr let us know if you have any comments :)

shashwathi commented 6 years ago

/check-cla

shashwathi commented 6 years ago

/assign @ImJasonH

knative-prow-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekcasey, ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/build-templates/blob/master/OWNERS)~~ [ImJasonH] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
googlebot commented 5 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ekcasey commented 5 years ago

We made some significant changes to this PR, so that the build template uses our the new v3alpha2 lifecycle. Now that the step image is configurable we also added some params to allow users to supply their own builder image.

We also fixed the template names in the buildpacks READMEs.

matthewmcnew commented 5 years ago

I was just added to the Pivotal group of authorized contributors so I should be covered by the corporate CLA. I am ok with my commits being contributed to this project

shashwathi commented 5 years ago

/check-cla

jamesward commented 5 years ago

Should the exporter step mount the docker socket and use -daemon?

sclevine commented 5 years ago

The CNB exporter is much less efficient when exporting to a daemon instead of a registry. When exporting to a registry, the exporter can upload just the layers that have changed, regardless of their order within the image.

Additionally, the whole process currently works in unprivileged containers. Poking the daemon socket through would make it less suitable for building untrusted code. (That said, I'm not sure what privileges containers currently have in build CRD.)

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

imjasonh commented 5 years ago

/lgtm