search

knative / build-templates

A library of build templates.
Apache License 2.0
184 stars 68 forks source link

add Amazon ECR helper #72

Closed AkihiroSuda closed 5 years ago

AkihiroSuda commented 5 years ago

Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp

mattmoor commented 5 years ago

/ok-to-test

AkihiroSuda commented 5 years ago

updated

AkihiroSuda commented 5 years ago

ping

dgerd commented 5 years ago

/lgtm

imjasonh commented 5 years ago

/lgtm /approve

Thanks!

knative-prow-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AkihiroSuda, ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/build-templates/blob/master/OWNERS)~~ [ImJasonH] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment