search

knative / build-templates

A library of build templates.
Apache License 2.0
184 stars 68 forks source link

Add s2i (source-to-image) build template #75

Closed vdemeester closed 5 years ago

vdemeester commented 5 years ago

This allows user to have similar build as Openshift source strategy build config.

Source-to-Image (S2I) is a toolkit and workflow for building reproducible Docker images from source code. S2I produces ready-to-run images by injecting source code into a Docker container and letting the container prepare that source code for execution. By creating self-assembling builder images, you can version and control your build environments exactly like you use Docker images to version your runtime environments.

cc @bbrowning @vbatts

Signed-off-by: Vincent Demeester vdemeest@redhat.com

vdemeester commented 5 years ago

@ImJasonH updated :wink:

vdemeester commented 5 years ago

@vbatts updated :wink:

vbatts commented 5 years ago

LGTM @ImJasonH ptal

knative-prow-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arilivigni, vdemeester, vorburger To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: mattmoor

If they are not already assigned, you can assign the PR to them by writing /assign @mattmoor in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/build-templates/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vorburger commented 5 years ago

/assign @mattmoor

vdemeester commented 5 years ago

As Knative Build is getting deprecated, and as there is a s2i Task in the Tekton Catalog, I am going to close that PR :angel: