search

knative / build-templates

A library of build templates.
Apache License 2.0
184 stars 68 forks source link

Add flag to disable the use of credential helpers #83

Closed philippthun closed 5 years ago

philippthun commented 5 years ago

By default the docker credential helpers for GCP, AWS, and Azure were used, while provided docker credentials were ignored. Setting the template argument USE_EXPORT_CREDENTIAL_HELPERS to false will override the default value of PACK_USE_HELPERS in packs/cf:export.

knative-prow-robot commented 5 years ago

Hi @philippthun. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
philippthun commented 5 years ago

Just saw that there is a parameter to disable credential helpers in https://github.com/knative/build-templates/pull/67 as well. As it was named differently, I've adjusted this PR to use the same name.

jchesterpivotal commented 5 years ago

Sorry for my slowness, I have been swinging the machete this afternoon to cut through the email jungle.

So as they say in the classics:

/lgtm

evankanderson commented 5 years ago

@ImJasonH

I think this needs your /approve

knative-prow-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, ImJasonH, philippthun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/build-templates/blob/master/OWNERS)~~ [ImJasonH] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment