search

knative / build-templates

A library of build templates.
Apache License 2.0
184 stars 68 forks source link

Cleanup cached and unnecessary files #88

Closed zouyee closed 5 years ago

zouyee commented 5 years ago

Cleanup cached and unnecessary files

knative-prow-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zouyee To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: mattmoor

If they are not already assigned, you can assign the PR to them by writing /assign @mattmoor in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/build-templates/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
imjasonh commented 5 years ago

@vbatts @vdemeester (aka "The Vincents"): does this change seem okay to you?

imjasonh commented 5 years ago

/ok-to-test

vbatts commented 5 years ago

LGTM

I thought we already were clean'ing, but that might have been dropped at some point

vdemeester commented 5 years ago

@vbatts ahah yeah, never got merge :upside_down_face: :roll_eyes: :stuck_out_tongue_closed_eyes:

zouyee commented 5 years ago

/close

knative-prow-robot commented 5 years ago

@zouyee: Closing this PR.

In response to [this](https://github.com/knative/build-templates/pull/88#issuecomment-464274875): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.