Closed johscheuer closed 5 years ago
Hi @johscheuer. Thanks for your PR.
I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.
ping @ImJasonH and @mattmoor
/lgtm /approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ImJasonH, johscheuer
The full list of commands accepted by this bot can be found here.
The pull request process is described here
This PR adds a simple BuildTemplate for makisu (https://github.com/uber/makisu). As soon as https://github.com/knative/build/pull/550 gets merged I would adjust the Secret Volume to be rendered by a Template Parameter rather than a hardcoded string.
Currently the makisu setup doesn't use a global build cache (mentioned here: https://github.com/uber/makisu#using-cache) if you want I can add an example for the global cache too.
Fixes: https://github.com/knative/build-templates/issues/77