knative / build-templates

A library of build templates.
Apache License 2.0
184 stars 68 forks source link

Add BuildTemplate for makisu #90

Closed johscheuer closed 5 years ago

johscheuer commented 5 years ago

This PR adds a simple BuildTemplate for makisu (https://github.com/uber/makisu). As soon as https://github.com/knative/build/pull/550 gets merged I would adjust the Secret Volume to be rendered by a Template Parameter rather than a hardcoded string.

Currently the makisu setup doesn't use a global build cache (mentioned here: https://github.com/uber/makisu#using-cache) if you want I can add an example for the global cache too.

Fixes: https://github.com/knative/build-templates/issues/77

knative-prow-robot commented 5 years ago

Hi @johscheuer. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
johscheuer commented 5 years ago

ping @ImJasonH and @mattmoor

imjasonh commented 5 years ago

/lgtm /approve

imjasonh commented 5 years ago

/lgtm

knative-prow-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH, johscheuer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/build-templates/blob/master/OWNERS)~~ [ImJasonH] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment