search

knative / build-templates

A library of build templates.
Apache License 2.0
184 stars 68 forks source link

Adds buildah template creation step in README #99

Open navidshaikh opened 5 years ago

navidshaikh commented 5 years ago

This change adds step in README to create buildah build-template.

vdemeester commented 5 years ago

/ok-to-test

knative-prow-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: navidshaikh, vdemeester To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: imjasonh

If they are not already assigned, you can assign the PR to them by writing /assign @imjasonh in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/build-templates/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
navidshaikh commented 5 years ago

/retest

knative-prow-robot commented 5 years ago

New changes are detected. LGTM label has been removed.

knative-prow-robot commented 5 years ago

@navidshaikh: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-build-templates-build-tests fe8caddd82b8ba350b19b9b8c5c6539d6c380c0c link /test pull-knative-build-templates-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
navidshaikh commented 5 years ago

The new update to patch includes fixes for errors caught while linting the markdown files as part of CI. Errors: ref logs, excerpts below

I0319 05:23:53.861] ---- Linting the markdown files ----
I0319 05:23:53.861] ------------------------------------
I0319 05:23:56.429] buildah/README.md:11: MD022 Headers should be surrounded by blank lines
I0319 05:23:56.430] buildah/README.md:12: MD031 Fenced code blocks should be surrounded by blank lines