search

knative / build

A Kubernetes-native Build resource.
Apache License 2.0
575 stars 159 forks source link

Don't generate dummy pod name #562

Closed tzununbekov closed 5 years ago

tzununbekov commented 5 years ago

Fixes #542

Dummy pod name from #519 makes API response unreliable:
https://github.com/knative/build/issues/542#issuecomment-459802297

Proposed Changes

MakePod function uses build.Status.Cluster.PodName to create new pod instead of generating new unique name

Release Note

NONE
imjasonh commented 5 years ago

/ok-to-test

knative-metrics-robot commented 5 years ago

The following is the coverage report on pkg/. Say /test pull-knative-build-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/build/build.go 75.9% 76.1% 0.2
pkg/reconciler/build/resources/pod.go 88.0% 85.4% -2.6
imjasonh commented 5 years ago

/lgtm /approve

knative-prow-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH, tzununbekov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/build/blob/master/OWNERS)~~ [ImJasonH] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment