Enforce timeouts outside of resyncs

knative / build

A Kubernetes-native Build resource.

Apache License 2.0

575 stars 159 forks source link

Enforce timeouts outside of resyncs #563

Closed tzununbekov closed 5 years ago

tzununbekov commented 5 years ago

Related to knative/build-pipeline#456 Unblocks #543

Probably should be merged after #562

Proposed Changes

Timeout checks removed from resync:

Each new build starts goroutine that waits for either stop signal, build finish or build timeout
On controller restart new goroutines are being created to track build timeouts
Mutexes added to safely update build statuses

Release Note

NONE

imjasonh commented 5 years ago

/ok-to-test

knative-metrics-robot commented 5 years ago

The following is the coverage report on pkg/. Say /test pull-knative-build-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/build/build.go	76.1%	69.5%	-6.6
pkg/reconciler/build/timeout_handler.go	Do not exist	67.3%

imjasonh commented 5 years ago

/lgtm /approve

knative-prow-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH, tzununbekov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/build/blob/master/OWNERS)~~ [ImJasonH] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment