search

knative / build

A Kubernetes-native Build resource.
Apache License 2.0
575 stars 159 forks source link

Set memory limits #572

Closed duglin closed 5 years ago

duglin commented 5 years ago

This is the "build" version of https://github.com/knative/serving/pull/3332

We're seeing OOM issues at the Node level when we don't set the limit. This will allow the pod to restart gracefully w/o taking down the entire node.

I'm not stuck on the specific value so we can pick a different one.

Signed-off-by: Doug Davis dug@us.ibm.com

Release Note

NONE

/lint

imjasonh commented 5 years ago

/test pull-knative-build-integration-tests /lgtm /approve

knative-prow-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: duglin, ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/build/blob/master/OWNERS)~~ [ImJasonH] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
imjasonh commented 5 years ago

/lgtm