Exit tailing logs for failed builds

knative / build

A Kubernetes-native Build resource.

Apache License 2.0

575 stars 159 forks source link

Exit tailing logs for failed builds #585

Closed shashwathi closed 5 years ago

shashwathi commented 5 years ago

Previously builds used to hang for failed builds with any non "buildExecuteFailed" reasons.

For more details: Fixes #579

Proposed Changes

Exit for any build failures

knative-prow-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shashwathi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/build/blob/master/OWNERS)~~ [shashwathi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

imjasonh commented 5 years ago

/lgtm