knative / build

A Kubernetes-native Build resource.
Apache License 2.0
575 stars 159 forks source link

Add a label knative.dev/crd-install to CRDs to allow installing CRDs in a separate pass. #588

Closed evankanderson closed 5 years ago

evankanderson commented 5 years ago

Proposed Changes

Release Note

- CRDs are now labelled with knative.dev/crd-install=true to allow installing without race conditions or kubectl errors.
knative-prow-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/build/blob/master/OWNERS)~~ [mattmoor] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
imjasonh commented 5 years ago

Is there a corresponding docs change to describe how to use these labels when installing?

evankanderson commented 5 years ago

There will be a docs change, which may need to be back-integrated into release-0.5