knative / build

A Kubernetes-native Build resource.
Apache License 2.0
575 stars 159 forks source link

Move to the v1beta1 Conditions implementation. #590

Closed mattmoor closed 5 years ago

mattmoor commented 5 years ago

See here for more context on what's changed (no breaking changes): https://github.com/knative/pkg/pull/361

knative-prow-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/build/blob/master/OWNERS)~~ [mattmoor] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knative-metrics-robot commented 5 years ago

The following is the coverage report on pkg/. Say /test pull-knative-build-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/build/build.go 69.5% 68.8% -0.8
mattmoor commented 5 years ago

/retest

imjasonh commented 5 years ago

/test pull-knative-build-integration-tests

knative-prow-robot commented 5 years ago

@mattmoor: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-build-integration-tests b72094862d0793e008814766a653ddefc54bee09 link /test pull-knative-build-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
vdemeester commented 5 years ago

@mattmoor knative/pkg now uses apps instead of extensions for Deployment (see https://github.com/knative/pkg/commit/8b3dc0d76d96f5ae9711e3e503f37c4c148129fc). Might be why the e2e fails