search

knative / build

A Kubernetes-native Build resource.
Apache License 2.0
575 stars 159 forks source link

Add timeout to kubectl delete to avoid later failures #595

Closed chaodaiG closed 5 years ago

chaodaiG commented 5 years ago

Fixes https://github.com/knative/test-infra/issues/676

Proposed Changes

By default, kubectl delete estimates a timeout if not provided, which makes the deletion not always guaranteed. Add timeout explicitly to avoid later failures

srinivashegde86 commented 5 years ago

/lgtm

chaodaiG commented 5 years ago

@srinivashegde86 , an approve label is missing

srinivashegde86 commented 5 years ago

/approve

knative-prow-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG, srinivashegde86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/OWNERS](https://github.com/knative/build/blob/master/test/OWNERS)~~ [srinivashegde86] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment