search

knative / build

A Kubernetes-native Build resource.
Apache License 2.0
575 stars 159 forks source link

git-init update and fixes #596

Closed vdemeester closed 5 years ago

vdemeester commented 5 years ago

Proposed Changes

Related to https://github.com/tektoncd/pipeline/pull/677 and https://github.com/tektoncd/pipeline/pull/750

Signed-off-by: Vincent Demeester vdemeest@redhat.com

knative-prow-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vdemeester To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: shashwathi

If they are not already assigned, you can assign the PR to them by writing /assign @shashwathi in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/build/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chmouel commented 5 years ago

Perhaps add this review too https://github.com/tektoncd/pipeline/pull/747

zouyee commented 5 years ago

I think path also need to be validated.

knative-prow-robot commented 5 years ago

@vdemeester: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-build-integration-tests 747e1cb046bb6a6e81d17065eadd3a12505af777 link /test pull-knative-build-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
imjasonh commented 5 years ago

Closing this as stale, please reopen if you think this is still something we should do.