search

knative / build

A Kubernetes-native Build resource.
Apache License 2.0
575 stars 159 forks source link

fix build uncorrect status #600

Closed zouyee closed 5 years ago

zouyee commented 5 years ago

Fixes https://github.com/knative/build/issues/599

Proposed Changes

Release Note

knative-prow-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zouyee To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: shashwathi

If they are not already assigned, you can assign the PR to them by writing /assign @shashwathi in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/build/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knative-metrics-robot commented 5 years ago

The following is the coverage report on pkg/. Say /test pull-knative-build-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/build/timeout_handler.go 67.3% 67.9% 0.6
imjasonh commented 5 years ago

Hi @zouyee -- sorry it's taken so long to get to this PR 😅

If this bug is still outstanding and reproducible, please add a test case that faiils without your code change to prevent accidentally regressing in some future refactor. A unit test change would also be nice.

imjasonh commented 5 years ago

Closing this as stale, please reopen if you think this is still something we should do.