search

knative / build

A Kubernetes-native Build resource.
Apache License 2.0
575 stars 159 forks source link

Change the name to signify that this is not handled like a normal go error #602

Closed Harwayne closed 5 years ago

Harwayne commented 5 years ago

Proposed Changes

This is similar to https://github.com/knative/serving/pull/3950 and https://github.com/knative/eventing/pull/1104

Release Note

NONE
knative-metrics-robot commented 5 years ago

The following is the coverage report on pkg/. Say /test pull-knative-build-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/build/build.go 68.8% 69.0% 0.2
knative-prow-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/build/blob/master/OWNERS)~~ [mattmoor] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment