search

knative / build

A Kubernetes-native Build resource.
Apache License 2.0
575 stars 159 forks source link

Consume the simplified controller constructor. #610

Closed mattmoor closed 5 years ago

mattmoor commented 5 years ago

See also: knative/pkg#427

/hold

This is RFAL, but shouldn't merge until the upstream change lands and this is reworked to consume it.

knative-prow-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/build/blob/master/OWNERS)~~ [mattmoor] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knative-prow-robot commented 5 years ago

@mattmoor: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-build-integration-tests 9c3e8a880964842af19df7cab1e345192016e567 link /test pull-knative-build-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
mattmoor commented 5 years ago

@ImJasonH I think the e2e test failure may be because Build is way behind on knative/pkg. Can you TAL?

imjasonh commented 5 years ago

@ImJasonH I think the e2e test failure may be because Build is way behind on knative/pkg. Can you TAL?

Just getting back to this now. It looks like the webhook controller isn't being registered, so no validation is happening at all:

..."msg":"failed to register webhook","knative.dev/controller":"webhook","error":"failed to fetch our deployment: deployments.apps \"build-webhook\" is forbidden: User \"system:serviceaccount:knative-build:build-controller\" cannot get deployments.apps in the namespace \"knative-build\"",...

Do you know any recent changes to knative/pkg that might be the culprit? Tests pass at knative/build head, using knative/pkg from March.

mattmoor commented 5 years ago

@ImJasonH I bet is was a change from beta apps to v1 apps, so changing the RBAC should fix this.

imjasonh commented 5 years ago

Superceded by #615