This has the same effect as #610 but it should actually enforce validation webhooks and pass e2e tests
Proposed Changes
dep ensure -update github.com/knative/pkg
dep ensure -update github.com/knative/test-infra (not ultimately necessary, but it shouldn't hurt)
Update pkg/reconciler/{build,buildtemplate,clusterbuildtemplate}/ to consume new simplified controller constructor (as #610)
At this point, e2e tests fail :boom:
Update config/200-clusterrole.yaml to request apps/deployments permissions instead of extensions/deployments (which is defunct) -- e2e tests pass :tada:
Release Note
Controller ClusterRole now requests `apps/deployments` permissions instead of defunct `extensions/deployments` -- these are necessary to enforce webhook validation.
Needs approval from an approver in each of these files:
- ~~[OWNERS](https://github.com/knative/build/blob/master/OWNERS)~~ [ImJasonH,shashwathi]
Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
This has the same effect as #610 but it should actually enforce validation webhooks and pass e2e tests
Proposed Changes
dep ensure -update github.com/knative/pkg
dep ensure -update github.com/knative/test-infra
(not ultimately necessary, but it shouldn't hurt)pkg/reconciler/{build,buildtemplate,clusterbuildtemplate}/
to consume new simplified controller constructor (as #610)config/200-clusterrole.yaml
to requestapps/deployments
permissions instead ofextensions/deployments
(which is defunct) -- e2e tests pass :tada:Release Note
cc @mattmoor