knative / build

A Kubernetes-native Build resource.
Apache License 2.0
575 stars 159 forks source link

Bump knative/pkg dependency, request apps/deployments RBAC permissions #615

Closed imjasonh closed 5 years ago

imjasonh commented 5 years ago

This has the same effect as #610 but it should actually enforce validation webhooks and pass e2e tests

Proposed Changes

Release Note

Controller ClusterRole now requests `apps/deployments` permissions instead of defunct `extensions/deployments` -- these are necessary to enforce webhook validation.

cc @mattmoor

knative-prow-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH, shashwathi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/build/blob/master/OWNERS)~~ [ImJasonH,shashwathi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment