knative / build

A Kubernetes-native Build resource.
Apache License 2.0
575 stars 159 forks source link

Remove hard coded images from go source files #651

Open scothis opened 5 years ago

scothis commented 5 years ago

Expected Behavior

Knative Build should only consume images declared in its configuration. This enables tools to scan what images will be consumed, and provide alternate images as needed

Actual Behavior

The gcr.io/cloud-builders/gcs-fetcher:latest image is defined in the source code. The other image arguments have stub values with actual values defined in the controller deployment. Because the image is not also specified in the yaml configuration, it requires special foreknowledge of Knative Build in order to properly configure the controller.

Additional Info

https://github.com/knative/build/blob/7e631989599ceda2ac51436fb8d1092c39d82bbb/pkg/reconciler/build/resources/pod.go#L103