search

knative / client-contrib

Community contributed `kn` plugins.
Apache License 2.0
10 stars 23 forks source link

[WIP]TEST DO NOT MERGE #1

Closed chizhg closed 4 years ago

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chizhg To complete the pull request process, please assign sixolet You can assign the PR to them by writing /assign @sixolet in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/client-contrib/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chizhg commented 4 years ago

/meow

knative-prow-robot commented 4 years ago

@chizhg: cat image

In response to [this](https://github.com/knative/client-contrib/pull/1#issuecomment-585957212): >/meow Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 4 years ago

@chizhg: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-client-contrib-unit-tests 8df1d8a5ecd2c7b272cfcd0ab3bd93ac071633db link /test pull-knative-client-contrib-unit-tests
pull-knative-client-contrib-build-tests 8df1d8a5ecd2c7b272cfcd0ab3bd93ac071633db link /test pull-knative-client-contrib-build-tests
pull-knative-client-contrib-go-coverage 8df1d8a5ecd2c7b272cfcd0ab3bd93ac071633db link /test pull-knative-client-contrib-go-coverage
pull-knative-client-contrib-integration-tests 8df1d8a5ecd2c7b272cfcd0ab3bd93ac071633db link /test pull-knative-client-contrib-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
chizhg commented 4 years ago

@rhuss , You'll need to vendor scripts in test-infra to get these tests passing.

rhuss commented 4 years ago

@chizhg I have now updated the tests scripts so that the overall CLI dispatches into individual plugin directories for tests (but only into those that are included in a PR). This makes the plugin builds independent from the repo CI (different e.g. than in eventing-contrib, where the dependencies are hardcoded).

The next step to create a top-level cluster setup, run the E2E for each plugin changed in a PR and then stop the cluster from the top-level again.

Thanks for the support, I'm going to close this test PR now.

knative-prow-robot commented 4 years ago

@chizhg: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.