knative / client-contrib

Community contributed `kn` plugins.
Apache License 2.0
10 stars 23 forks source link

the root e2e-tests.sh #13

Open daisy-ycguo opened 4 years ago

daisy-ycguo commented 4 years ago

Currently, the root e2e-tests.sh does nothing except loop calling the e2e-test.sh under every single plugin. I think there are a few common set up steps that we might want to let the root e2e-tests.sh to handle:

@rhuss please share your thoughts to this two requirments.

rhuss commented 4 years ago

Totally agree, I just not have implemented it yet ;-) (although a "good" PR should only contain change to a single plugin and so only this plugin tests' are called for a specific PR, so only fire up a single cluster only, too).

Having test hooks sounds fine for me, but I think this can be already done by overriding some functions from the test-infra e2e-tests.sh script. But I will check.