search

knative / client-contrib

Community contributed `kn` plugins.
Apache License 2.0
10 stars 23 forks source link

chore: Some fixes to tests and "kn admin" #20

Closed rhuss closed 4 years ago

rhuss commented 4 years ago

@daisy-ycguo if you comment with /lgtm then the PR should be merged, too. (i.e. the condition for merging is: 'approved' + 'lgtm', but any PR created by an approver is auto-approved, so only needs a 'lgtm' which can be set by any member of the Knative githup orga.

zhanggbj commented 4 years ago

/lgtm

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daisy-ycguo, rhuss, zhanggbj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/client-contrib/blob/master/OWNERS)~~ [rhuss,zhanggbj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment