search

knative / client-contrib

Community contributed `kn` plugins.
Apache License 2.0
10 stars 23 forks source link

[kn-admin]Add support to enable or disable scale-to-zero #26

Closed zhanggbj closed 4 years ago

zhanggbj commented 4 years ago

User Story: As a Knative administrator, I want to enable and disable scale to zero for Knative platform.

It might be desirable for Knative admins to enable or disable scale-to-zero for a specific Knative installation frequently, which is also discussed in https://github.com/knative/client-contrib/issues/18. The kn-admin plugin will enable/disable this feature via the CLI instead of modifying ConfigMap. We can use this PR for further discussion on it. Thanks!

Note: please merge PR #25 first and then I'll rebase this one on it.

PR:

zhanggbj commented 4 years ago

Thanks for your code review!

@rhuss Thanks for point it out. I'll refine this PR to follow the same UX with cli to use --scale-to-zero and --no-scale-to-zero.

@maximilien Same with above will refine it^^ for unset. And I'm working on another item to fill up UT and e2e test #14. So for the future PR, will raise them with test files.

zhanggbj commented 4 years ago

All comments addressed, it's ready for review, thanks!

zhanggbj commented 4 years ago

Hi @rhuss @maximilien,

All comments addressed, would you please help to review again, thanks!

zhanggbj commented 4 years ago

will wait for #14 to add more UT and e2e test

zhanggbj commented 4 years ago

As @rhuss have approved it and I filled up UT just now, @rhuss @maximilien would you please help to take a review, thanks!

knative-prow-robot commented 4 years ago

@zhanggbj: you cannot LGTM your own PR.

In response to [this](https://github.com/knative/client-contrib/pull/26#issuecomment-637333326): >As @rhuss have added lgtm and I filled up UT later, so I'll merge it. >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
zhanggbj commented 4 years ago

Hi @rhuss @maximilien ,

Would you please help to take a review, the last update is to fill up UT, thank you!

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhuss, zhanggbj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[plugins/admin/OWNERS](https://github.com/knative/client-contrib/blob/master/plugins/admin/OWNERS)~~ [rhuss,zhanggbj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment