search

knative / client-contrib

Community contributed `kn` plugins.
Apache License 2.0
10 stars 23 forks source link

As knative admin, I want to unset custom domain #29

Closed ZhuangYuZY closed 4 years ago

ZhuangYuZY commented 4 years ago

Now we have kn admin domain set to set custom-domain. But we are missing to unset the custom domain if it is not used or incorrect. 

unset Knative route domain for service

For example:
# To unset a route domain
kn admin domain unset --custom-domain mydomain.com

Usage:
  kn admin domain unset [flags]

Flags:
  -d, --custom-domain string  Custom domain to unset
  -h, --help                   help for unset

Global Flags:
      --config string   config file (default is $HOME/.config/kn/plugins/admin.yaml)
ZhuangYuZY commented 4 years ago

/assign I would work on this new command.

ZhuangYuZY commented 4 years ago

Function code is ready, now I am waiting on https://github.com/knative/client-contrib/issues/14, then add test for unset. Thank you.

ZhuangYuZY commented 4 years ago

PR submitted, https://github.com/knative/client-contrib/pull/38

ZhuangYuZY commented 4 years ago

PR merged, closing...