search

knative / client-contrib

Community contributed `kn` plugins.
Apache License 2.0
10 stars 23 forks source link

Initialize kn image plugin #3

Closed zhangtbj closed 4 years ago

zhangtbj commented 4 years ago

Hi All,

This kn-image plugin is designed to help developer build their container image from source code and deploy the image to Knative.

This is an initial commit. More details in the proposal: https://docs.google.com/document/d/1dwg-ffA7GGwSFtWQVgdhW1sZCC5s_Oh0Tq9xqbI_N0I/edit?usp=sharing

Thanks!

knative-prow-robot commented 4 years ago

Welcome @zhangtbj! It looks like this is your first PR to knative/client-contrib 🎉

knative-prow-robot commented 4 years ago

Hi @zhangtbj. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhangtbj To complete the pull request process, please assign mattmoor You can assign the PR to them by writing /assign @mattmoor in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/client-contrib/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
maximilien commented 4 years ago

/ok-to-test

maximilien commented 4 years ago

Hi, @zhangtbj, all tests failing? OR no tests. Please address.

I will find some time to also leave some comments today or tomorrow.

zhangtbj commented 4 years ago

Hi @maximilien ,

I discussed with Roland before, in this thread: https://knative.slack.com/archives/CE4MVFVAQ/p1581581004100600

He said he is still defining the test framework for the client-contrib.

And he agreed that we can provide the first plugin without test

knative-prow-robot commented 4 years ago

@zhangtbj: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-client-contrib-build-tests 9ddbd7c6fc246c4ea4406e8573dcc51fb24dc1e0 link /test pull-knative-client-contrib-build-tests
pull-knative-client-contrib-integration-tests 9ddbd7c6fc246c4ea4406e8573dcc51fb24dc1e0 link /test pull-knative-client-contrib-integration-tests
pull-knative-client-contrib-unit-tests 9ddbd7c6fc246c4ea4406e8573dcc51fb24dc1e0 link /test pull-knative-client-contrib-unit-tests
pull-knative-client-contrib-go-coverage 9ddbd7c6fc246c4ea4406e8573dcc51fb24dc1e0 link /test pull-knative-client-contrib-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
zhangtbj commented 4 years ago

Hi @maximilien ,

I have fixed the issues. Please review again. Thanks!