As knative admin, I want to list custom domains

knative / client-contrib

Community contributed `kn` plugins.

Apache License 2.0

10 stars 23 forks source link

As knative admin, I want to list custom domains #30

Open ZhuangYuZY opened 4 years ago

ZhuangYuZY commented 4 years ago

Now we have kn admin domain set to set custom-domain. But we are missing a list command to show custom domains.

List Knative custom domain

Usage:
  kn admin domain list [flags]

Examples:

  # To list all custom domains
  kn admin domain list

Flags:
  -h, --help         help for list
      --no-headers   When using the default output format, don't print headers (default: print headers).

Global Flags:
      --config string   config file (default is $HOME/.config/kn/plugins/admin.yaml)

ZhuangYuZY commented 4 years ago

@zhanggbj Based on our talk, there is pkg for format output. Could you please give a reference to implement domain list ? Thank you

ZhuangYuZY commented 4 years ago

/assign I also work on this new command.

zhanggbj commented 4 years ago

@ZhuangYuZY As kn-admin is a plugin of kn client, I think it's good to align with kn client, althrough there're some common go pkg for printer.

Here is the pkg from kn client "knative.dev/client/pkg/printers"
We can refer to route list here

One concern from my side, if we're going to list all, I think there's no need to specify flags --custom-domain any more.

ZhuangYuZY commented 4 years ago

I remove the --custom-domain flag. Thank you.

ZhuangYuZY commented 4 years ago

https://github.com/knative-sandbox/kn-plugin-admin/pull/3 created