Update test-infra scripts to the "official" way

knative / client-contrib

Community contributed `kn` plugins.

Apache License 2.0

10 stars 23 forks source link

Update test-infra scripts to the "official" way #35

Closed rhuss closed 4 years ago

rhuss commented 4 years ago

lgtm

@daisy-ycguo if you use /lgtm (mind the /) then the PR would be merged :) (as this is a Prow command to add a "lgtm" label, and as soon as a PR has both "approved" and "lgtm" as labels its auto-merged. It is "approved" already because every PR from an approver in the OWNERS file gets automatically the "approved" label)

knative-prow-robot commented 4 years ago

@navidshaikh: changing LGTM is restricted to collaborators

In response to [this](https://github.com/knative/client-contrib/pull/35#pullrequestreview-419233038): >/lgtm >/approve Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daisy-ycguo, navidshaikh, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/client-contrib/blob/master/OWNERS)~~ [rhuss] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

dsimansk commented 4 years ago

/lgtm

zhangtbj commented 4 years ago

/lgtm