search

knative / client-contrib

Community contributed `kn` plugins.
Apache License 2.0
10 stars 23 forks source link

Update go.mod to specify the module is go1.14 #36

Closed dprotaso closed 4 years ago

dprotaso commented 4 years ago

Thus the go commands will default to -mod=vendor

See: https://golang.org/doc/go1.14#go-command

navidshaikh commented 4 years ago

/hold

dprotaso commented 4 years ago

CI should be using go1.14 now. The error is a bit confusing so I'm curious if it's not forcing our k8s deps to be the right version (ie. v0.17.6)

dprotaso commented 4 years ago

@navidshaikh this should be good now

dprotaso commented 4 years ago

/unhold

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, maximilien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/client-contrib/blob/master/OWNERS)~~ [maximilien] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment