Closed ZhuangYuZY closed 4 years ago
Welcome @ZhuangYuZY! It looks like this is your first PR to knative/client-contrib 🎉
Hi @ZhuangYuZY. Thanks for your PR.
I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
Hi @rhuss, I remember you have a contact to help us join Knative Org, would you please help to add @ZhuangYuZY in Knative Org, or any guide we can follow? Thanks!
@ZhuangYuZY The PR looks good! And I think it's good to have the following updates with this PR.
@zhanggbj refining is done based on your comments. Thank you.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: zhanggbj, ZhuangYuZY
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
@ZhuangYuZY Great and Merged 👍
For issue https://github.com/knative/client-contrib/issues/29:
Now we have kn admin domain set to set custom-domain. But we are missing to unset the custom domain if it is not used or incorrect.
unset Knative route domain for service
For example:
To unset a route domain
kn admin domain unset --custom-domain mydomain.com
Usage: kn admin domain unset [flags]
Flags: -d, --custom-domain string Custom domain to unset -h, --help help for unset
Global Flags: --config string config file (default is $HOME/.config/kn/plugins/admin.yaml)