search

knative / client-contrib

Community contributed `kn` plugins.
Apache License 2.0
10 stars 23 forks source link

[kn-curl] feature: initial kn curl plugin #4

Closed maximilien closed 4 years ago

maximilien commented 4 years ago
  1. initial PR for kn-curl plugin
  2. first BASH plugin
  3. missing some features (see Next Steps in README) that will be solved in next iteration
knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/client-contrib/blob/master/OWNERS)~~ [maximilien] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
maximilien commented 4 years ago

/ok-to-test

knative-prow-robot commented 4 years ago

@maximilien: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-client-contrib-go-coverage ae8a75223cf6c1273ef83d32e74a29dcf4c6885c link /test pull-knative-client-contrib-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
knative-prow-robot commented 4 years ago

@maximilien: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
maximilien commented 4 years ago

Update: Finally getting back to this. I am planning to address all feedback this week as well as updated README.md

maximilien commented 4 years ago

Closing this. Will be submitting a better and different one. This was submitted before we had the recommended structure for plugins