knative / client-contrib

Community contributed `kn` plugins.
Apache License 2.0
10 stars 23 forks source link

[kn-admin] kn-admin has different behaviour on minikube knative #42

Closed chaozbj closed 4 years ago

chaozbj commented 4 years ago

Environment

System: MacOS 10.15.4 Minikube: v1.11.0 Kubectl client: v1.15.5 Kubectl server: v1.18.2 Knative: v0.12.0

Commands to Run

  1. ./kn-admin domain set -d test.com --selector app=prod --selector app=stage
  2. ./kn-admin autoscaling update --scale-to-zero

Results and Logs

  1. For the domain command, I checked the config-domain, the test.com with the selectors is set, but there is an unexpected line ---- between domain and selector:
    
    test.com:
    ----
    selector:
    app: prod
    app: stage

Events:

2. For the autoscaling command, I found that the ```enable-scale-to-zero``` is set to with boolean value instead of string value:
```yaml
enable-scale-to-zero:
----
true
Events:  <none>

I talked to @zhanggbj and she said there is no redundant line: ---- and the value is set to string not boolean on kube cluster. We will take time to investigate why the behaviour is different on minikube.

zhanggbj commented 4 years ago

@chaozbj good findings! I did tests on IBM IKS clusters and it works fine, there's some error for minikube support. Need further investigation. Thx!

chaozbj commented 4 years ago

I wrote a simple application to change a configMap in default namespace, I planed to open an issue in minikube repo to ask and use this app as the example to explain my question. But when I tried to run it locally with my minikube, I can't reproduce this issue now. And then, I tried to use kn-admin to set a domain, still can't reproduce. I don't know why, the only difference is that I recreated minikube cluster and reinstalled knative, but their versions are same. Since I can't reproduce it, I would like to close it.

chaozbj commented 4 years ago

I will close it. I will continue to use minikube in my local environment, if I meet the same problem again. I will open a new issue for it.