search

knative / client-contrib

Community contributed `kn` plugins.
Apache License 2.0
10 stars 23 forks source link

[kn-source-github] first version of the kn-source-github plugin #46

Open maximilien opened 4 years ago

maximilien commented 4 years ago

Includes:

Missing:

Fixes #10 and #34

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/client-contrib/blob/master/OWNERS)~~ [maximilien] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
maximilien commented 4 years ago

/hold

knative-prow-robot commented 3 years ago

@daisy-ycguo: The /test command needs one or more targets. The following commands are available to trigger jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/knative/client-contrib/pull/46#issuecomment-694075299): >/test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
daisy-ycguo commented 3 years ago

/test all

daisy-ycguo commented 3 years ago

@maximilien Hello, dr.max. Currently, the integration test runs nothing, because you don't have an e2e-tests.sh under plugins/source-github/test, just a local-e2e-tests.sh. The integration test framework used by client-contrib is designed to call plugins/source-github/test/e2e-tests.sh for the e2e test of every plugin. So please add a plugins/source-github/test/e2e-tests.sh to your plugin. You may just copy the same of local-e2e-tests.sh. Thanks.

maximilien commented 3 years ago

Thanks @daisy-ycguo will do.

knative-prow-robot commented 3 years ago

@maximilien: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 3 years ago

@maximilien: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-client-contrib-integration-tests 897f796167136bac559f8779b25d7b6c327b6bf8 link /test pull-knative-client-contrib-integration-tests
pull-knative-client-contrib-build-tests 897f796167136bac559f8779b25d7b6c327b6bf8 link /test pull-knative-client-contrib-build-tests
pull-knative-client-contrib-unit-tests 897f796167136bac559f8779b25d7b6c327b6bf8 link /test pull-knative-client-contrib-unit-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).