Closed 12345lcr closed 4 years ago
Welcome @12345lcr! It looks like this is your first PR to knative/client-contrib 🎉
Hi @12345lcr. Thanks for your PR.
I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
@12345lcr Generally it looks very good! Just a few minor comments as above.
Also could you please help to update the examples for registry rm
and user stories in https://github.com/knative/client-contrib/blob/master/plugins/admin/README.adoc? Thanks!
@rhuss would you please help to add @12345lcr to knative org, or do you have the knative admin contract name? Thanks!
You can ask in #steering-toc-questions or for now ping @evankanderson directly. I'm off because of holidays here in Germany and back on Monday.
@zhanggbj @chaozbj @maximilien Thank you all for reviewing and I am really appreciate it! I just updated the pr with comments addressed, feel free to review again and leave any comments.
@12345lcr LGTM. But would you please also add ab example for registry rm
in https://github.com/knative/client-contrib/blob/master/plugins/admin/README.adoc as others? Thanks!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: 12345lcr, zhanggbj
The full list of commands accepted by this bot can be found here.
The pull request process is described here
LGTM 👍 just noticed @maximilien have requested for change, not sure If Max got further comments. If not, I'll merge it by end of today. Thanks @12345lcr for your PR and patience!!!
/lgtm
For issue: https://github.com/knative/client-contrib/issues/39
As a Knative administrator, I want to remove registry with credentials for Knative platform through username and server url.