search

knative / client-contrib

Community contributed `kn` plugins.
Apache License 2.0
10 stars 23 forks source link

Update cluster-setup to compile kn properly #50

Closed rhuss closed 4 years ago

rhuss commented 4 years ago

Also, update hello plugin to cobra 1.0

rhuss commented 4 years ago

@daisy-ycguo I think we can merge that and then the issue on the non-vendor PR would be gone, too.

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/client-contrib/blob/master/OWNERS)~~ [maximilien,rhuss] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
maximilien commented 4 years ago

/lgtm