[kn-curl] with support for namespace and better help

knative / client-contrib

Community contributed `kn` plugins.

Apache License 2.0

10 stars 23 forks source link

[kn-curl] with support for namespace and better help #52

Open maximilien opened 4 years ago

maximilien commented 4 years ago

kn-curl second attempt

supports namespace
better help usage message matching kn style
supports -h and --help

Supports getting INGRESS with Istio. Needs to following:

[x] needs to be updated to support other ingress types.
[x] needs at least an integration test and run in new vendor-less fashion.

maximilien commented 4 years ago

Thanks for review @navidshaikh 🙏🏽

Will address comments today. Best.

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/client-contrib/blob/master/OWNERS)~~ [maximilien,navidshaikh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

maximilien commented 4 years ago

Great feedback @rhuss and @navidshaikh. Addressing. Thank you 🙏

knative-prow-robot commented 4 years ago

New changes are detected. LGTM label has been removed.

maximilien commented 4 years ago

OK latest update addresses all comments except for the two TODOs I had: 1) e2e tests (almost done) and 2) other ingress, have not started this...

maximilien commented 4 years ago

Added checks for istio and first e2e tests. Need to address some of auto the linting feedback

maximilien commented 3 years ago

/hold remove

maximilien commented 3 years ago

/unhold

maximilien commented 3 years ago

@navidshaikh can I get a final review and LGTM on this? Thanks