search

knative / client-contrib

Community contributed `kn` plugins.
Apache License 2.0
10 stars 23 forks source link

[kn-admin] Refine subcommand wording #53

Open zhanggbj opened 4 years ago

zhanggbj commented 4 years ago

Per discussion in https://github.com/knative/client-contrib/pull/40#discussion_r437917155

now in kn-admin, for different subcommand domain/registry, we're using add/update/etc for create/update actions. We should be consistent in kn-admin.

kn client has a story to use create/apply/remove. We can follow the same way to keep same user experience.

chaozbj commented 4 years ago

/assign I would like to work on it.

zhanggbj commented 4 years ago

@chaozbj Could you please also take care of this https://github.com/knative/client-contrib/pull/47#discussion_r443319833? Thanks!

chaozbj commented 4 years ago

@zhanggbj ok, no prblem

chaozbj commented 4 years ago

I would like to put it on hold because kn client has the similar feature and waits for implementation: https://github.com/knative/client/issues/655, we will follow kn client to introduce create/apply/remove in our plugin.

chaozbj commented 3 years ago

The codes have been merged, will close it. /close

knative-prow-robot commented 3 years ago

@chaozbj: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to [this](https://github.com/knative/client-contrib/issues/53#issuecomment-668499715): >The codes have been merged, will close it. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.