search

knative / client-contrib

Community contributed `kn` plugins.
Apache License 2.0
10 stars 23 forks source link

Improve domain subcommands and some wording suggestions #62

Closed chaozbj closed 4 years ago

chaozbj commented 4 years ago

This PR is mainly used to address the issue: #41 and some wording suggestions from PR: #40:

  1. Return error for invalid --selector value when using domain set subcommand
  2. Add UT for adding domain with invalid selector
  3. Improve help and error message for domain set subcommand
  4. Remove For example: xxx from admin root command
  5. Set SilenceUsage: true for admin root command to keep the same behaivour as kn client
  6. Improve wording according to suggestions from: #40 (comment)
knative-prow-robot commented 4 years ago

Hi @chaozbj. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
zhanggbj commented 4 years ago

/ok-to-test

chaozbj commented 4 years ago

@navidshaikh: could you please help me review this RP since it addressed some wording improvements according to your suggestions in RP: #40? Thanks!

chaozbj commented 4 years ago

@maximilien @zhanggbj @navidshaikh @12345lcr I addressed your comments, please help to review again. Thanks!

chaozbj commented 4 years ago

@maximilien I added a UT case for checking if the usage of root command has kn admin, please help to review again, thanks!

chaozbj commented 4 years ago

@navidshaikh @zhanggbj @12345lcr Following the comments https://github.com/knative/client-contrib/pull/47#discussion_r443319833, I changed the flag from --secret-name to --secret for registry add, please help to review, thanks!

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaozbj, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[plugins/admin/OWNERS](https://github.com/knative/client-contrib/blob/master/plugins/admin/OWNERS)~~ [navidshaikh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
navidshaikh commented 4 years ago

/unhold